Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rename comment_test.rb to comment_system_test.rb #11642

Closed
wants to merge 1 commit into from
Closed

Update and rename comment_test.rb to comment_system_test.rb #11642

wants to merge 1 commit into from

Conversation

canlpy
Copy link

@canlpy canlpy commented Jul 9, 2023 •
edited
Loading

Fixes #0000

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@welcome
Copy link

welcome bot commented Jul 9, 2023

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄


One thing that can help to get started is to make sure you've included a link back to the original issue you're solving, in the format fixes #0000 (for example). And to make sure the PR title describes what you're trying to do! (often it can be the same as the issue title) Thanks! 🙌


Then, you can say hello in our chatroom & share a link to this PR to get a review! 👋 ✅

@codeclimate
Copy link

codeclimate bot commented Jul 9, 2023

Code Climate has analyzed commit e4bfa0e and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jul 9, 2023

Codecov Report

Merging #11642 (80dd8a9) into main (5e1d8c2) will decrease coverage by 3.81%.
The diff coverage is n/a.

❗ Current head 80dd8a9 differs from pull request most recent head e4bfa0e. Consider uploading reports for the commit e4bfa0e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11642      +/-   ##
==========================================
- Coverage   83.33%   79.52%   -3.81%     
==========================================
  Files          93       93              
  Lines        5772     5792      +20     
==========================================
- Hits         4810     4606     -204     
- Misses        962     1186     +224

see 28 files with indirect coverage changes

@canlpy canlpy closed this by deleting the head repository Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@canlpy